[Backport 2.x] merge feature/mds branch into main #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Support MDS on List, Detail, Dashboard, Overview pages (#722) * update snapshots Signed-off-by: Jackie Han <[email protected]> * add snpshot Signed-off-by: Jackie Han <[email protected]> * add data source client Signed-off-by: Jackie Han <[email protected]> * test * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <[email protected]> * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * test Signed-off-by: Jackie Han <[email protected]> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <[email protected]> * change 4/7 Signed-off-by: Jackie Han <[email protected]> * version change Signed-off-by: Jackie Han <[email protected]> * list detector list change Signed-off-by: Jackie Han <[email protected]> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <[email protected]> * change version back to 3.0 Signed-off-by: Jackie Han <[email protected]> * revert version change Signed-off-by: Jackie Han <[email protected]> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <[email protected]> * update imports Signed-off-by: Jackie Han <[email protected]> * remove used function Signed-off-by: Jackie Han <[email protected]> * cleanup Signed-off-by: Jackie Han <[email protected]> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <[email protected]> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <[email protected]> * addressing comments and run prettier Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <[email protected]> * add comment Signed-off-by: Jackie Han <[email protected]> * make dataSourceId type safe Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> * add MDS support for detector creation&Update flow (#728) * update snapshots Signed-off-by: Jackie Han <[email protected]> * add snpshot Signed-off-by: Jackie Han <[email protected]> * add data source client Signed-off-by: Jackie Han <[email protected]> * test * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * add opensearch_dashboards.json file Signed-off-by: Jackie Han <[email protected]> * neo List Detectors page Signed-off-by: Jackie Han <[email protected]> * test Signed-off-by: Jackie Han <[email protected]> * Support MDS on DetectorDetails page Signed-off-by: Jackie Han <[email protected]> * change 4/7 Signed-off-by: Jackie Han <[email protected]> * version change Signed-off-by: Jackie Han <[email protected]> * list detector list change Signed-off-by: Jackie Han <[email protected]> * Support MDS on List, Detail, Dashboard, Overview pages Signed-off-by: Jackie Han <[email protected]> * change version back to 3.0 Signed-off-by: Jackie Han <[email protected]> * revert version change Signed-off-by: Jackie Han <[email protected]> * make dataSourceId optional in DetectorListItem type Signed-off-by: Jackie Han <[email protected]> * update imports Signed-off-by: Jackie Han <[email protected]> * remove used function Signed-off-by: Jackie Han <[email protected]> * cleanup Signed-off-by: Jackie Han <[email protected]> * add getter and setter for dataSource plugin Signed-off-by: Jackie Han <[email protected]> * read dataSourceId from the url instead of passing props Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * addressing comments and run prettier Signed-off-by: Jackie Han <[email protected]> * addressing comments in neo1 branch Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * make getDataSourceManagementPlugin() optional Signed-off-by: Jackie Han <[email protected]> * add comment Signed-off-by: Jackie Han <[email protected]> * make dataSourceId type safe Signed-off-by: Jackie Han <[email protected]> * add MDS support on creation page Signed-off-by: Jackie Han <[email protected]> * updated methods to get data source query param from url Signed-off-by: Jackie Han <[email protected]> * using helper to construct url with dataSourceId Signed-off-by: Jackie Han <[email protected]> * add update page, and update urls on detector detail page Signed-off-by: Jackie Han <[email protected]> * update update call router Signed-off-by: Jackie Han <[email protected]> * update reducer and router Signed-off-by: Jackie Han <[email protected]> * clean up Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * update enums Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> * update actionOption attribution for all data soure components (#732) Signed-off-by: Jackie Han <[email protected]> * Add MDS UTs and bug fixes (#734) * working on ut Signed-off-by: Jackie Han <[email protected]> * update ut Signed-off-by: Jackie Han <[email protected]> * update UTs and add bug fixes Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> * bug fixes (#737) Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> (cherry picked from commit 48acb93)
opensearch-trigger-bot
bot
requested review from
ohltyler,
kaituo,
jackiehanyang,
amitgalitz,
sean-zheng-amazon,
dbwiddis,
owaiskazi19 and
joshpalis
as code owners
jackiehanyang
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 48acb93 from #739